Cargo.toml

@@ -5,24 +5,9 @@ edition = "2021"
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
-default-run = "proxy"
-
-[[bin]]
-name = "proxy"
-path = "src/bin/proxy.rs"
-
-[[bin]]
-name = "ping-server"
-path = "src/bin/ping_server.rs"
-
-[[bin]]
-name = "ping-client"
-path = "src/bin/ping_client.rs"
-
 [dependencies]
 anyhow = "1.0.69"
 axum = { version = "0.6.11", features = ["json"] }
-clap = { version = "4.3.0", features = ["derive"] }
 p384 = { version = "0.13.0", features = ["ecdsa", "serde"] }
 serde = { version = "1.0.155", features = ["derive"] }
 serde_json = "1.0.94"

create.sh

@@ -7,4 +7,4 @@ curl --header "Content-Type: application/json" \
                     "id": "67e55044-10b1-426f-9247-bb680e5fe0c8"
             }
           }' \
-  http://localhost:14000/command
+  http://localhost:3000/command

modify.sh

@@ -6,4 +6,4 @@ curl --header "Content-Type: application/json" \
                     "id": "67e55044-10b1-426f-9247-bb680e5fe0c8"
                   }
           }' \
-  http://localhost:14000/command
+  http://localhost:3000/command

modifyback.sh

@@ -6,4 +6,4 @@ curl --header "Content-Type: application/json" \
                     "id": "67e55044-10b1-426f-9247-bb680e5fe0c8"
                   }
           }' \
-  http://localhost:14000/command
+  http://localhost:3000/command

src/bin/ping_client.rs

@@ -1,100 +0,0 @@
-use clap::Parser;
-use std::net::SocketAddrV4;
-use std::str::FromStr;
-use std::sync::{
-    atomic::{AtomicBool, AtomicU32, Ordering},
-    Arc, Mutex,
-};
-use std::time::{Duration, Instant};
-use tokio::{
-    io::{AsyncReadExt, AsyncWriteExt},
-    net::TcpStream,
-    time::sleep,
-};
-
-#[tokio::main]
-async fn main() {
-    let args = Args::parse();
-
-    let in_transit = Arc::new(AtomicBool::new(false));
-    let in_transit2 = in_transit.clone();
-    let out_timestamp = Arc::new(Mutex::new(Instant::now()));
-    let out_timestamp2 = out_timestamp.clone();
-    let count = AtomicU32::new(args.count);
-
-    let addr = SocketAddrV4::from_str(&args.address).unwrap();
-
-    let stream = TcpStream::connect(addr).await.unwrap();
-    if !args.csv {
-        println!("Ping {addr}");
-    }
-
-    let (mut si, mut so) = stream.into_split();
-
-    let ping_in = async move {
-        let mut read_buf = [0; 1024];
-        while count.load(Ordering::Relaxed) > 0 {
-            let bytes = si.read(&mut read_buf).await.unwrap();
-            if bytes > 0 {
-                let in_timestamp = Instant::now();
-                // println!("Received {bytes} bytes");
-
-                let duration = in_timestamp.duration_since(*out_timestamp.lock().unwrap());
-                let i = u32::from_be_bytes(read_buf[0..bytes].try_into().unwrap());
-                let rtt = duration.as_micros();
-                if !args.csv {
-                    println!("Ping {i} arrived with RTT of {rtt}us");
-                } else {
-                    println!("{rtt},");
-                }
-                // let old = count.fetch_sub(1, Ordering::Relaxed);
-                // println!("Old count value: {old}");
-                count.fetch_sub(1, Ordering::Relaxed);
-                in_transit2.store(false, Ordering::Relaxed);
-            }
-        }
-        if !args.csv {
-            println!("Done receiving");
-        }
-    };
-
-    let ping_out = async move {
-        for i in 1..=args.count {
-            if let Ok(false) =
-                in_transit.compare_exchange_weak(false, true, Ordering::Relaxed, Ordering::Relaxed)
-            {
-                *out_timestamp2.lock().unwrap() = Instant::now();
-                so.write_u32(i).await.unwrap();
-            }
-
-            if !args.csv {
-                println!("Sending ping {i}");
-            }
-            sleep(Duration::from_millis(args.time)).await;
-        }
-        if !args.csv {
-            println!("Done sending pings");
-        }
-    };
-
-    tokio::join!(ping_out, ping_in);
-}
-
-#[derive(Parser, Debug)]
-struct Args {
-    /// Socket address to ping
-    #[arg(long)]
-    address: String,
-
-    /// Amount of pings to send
-    #[arg(short, long)]
-    count: u32,
-
-    /// Time between pings
-    #[arg(short, long)]
-    time: u64,
-
-    /// CSV mode
-    #[arg(long)]
-    csv: bool,
-}

src/bin/ping_server.rs

@@ -1,33 +0,0 @@
-use clap::Parser;
-use std::error::Error;
-use std::net::SocketAddrV4;
-use std::str::FromStr;
-use tokio::io::AsyncWriteExt;
-use tokio::{io, net::TcpListener};
-
-#[tokio::main]
-async fn main() -> Result<(), Box<dyn Error>> {
-    let args = Args::parse();
-
-    let addr = SocketAddrV4::from_str(&args.address).unwrap();
-
-    let listener = TcpListener::bind(&addr).await?;
-    println!("Listening on: {addr}");
-
-    loop {
-        let (mut socket, _) = listener.accept().await?;
-
-        tokio::spawn(async move {
-            let (mut si, mut so) = socket.split();
-            io::copy(&mut si, &mut so).await?;
-            so.shutdown().await
-        });
-    }
-}
-
-#[derive(Parser, Debug)]
-struct Args {
-    /// Socket address to listen on
-    #[arg(long)]
-    address: String,
-}

src/lib.rs

@@ -7,7 +7,6 @@ use std::collections::{HashMap, HashSet};
 use std::net::{IpAddr, SocketAddr};
 use std::str::FromStr;
 use std::sync::{Arc, Mutex, RwLock};
-use std::time;
 use tokio::io::{self, AsyncWriteExt};
 use tokio::net::{TcpListener, TcpStream};
 use tokio::sync::watch::{self, Receiver, Sender};
@@ -17,7 +16,6 @@ use uuid::Uuid;
 pub struct ProxyCommand {
     #[serde(flatten)]
     command: Command,
-    timestamp: Option<u64>,
     signature: Option<Signature>,
 }
 
@@ -25,34 +23,8 @@ impl ProxyCommand {
     fn verify_signature(&self, verifying_key: &Option<VerifyingKey>) -> bool {
         match (verifying_key, &self.signature) {
             (Some(key), Some(signature)) => {
-                let mut message = serde_json::to_string(&self.command).unwrap();
+                let message = serde_json::to_string(&self.command).unwrap();
-
+                key.verify(message.as_bytes(), signature).is_ok()
-                let timestamp = if let Some(timestamp) = self.timestamp {
-                    message.push_str(&timestamp.to_string());
-                    time::Duration::from_secs(timestamp)
-                } else {
-                    tracing::debug!("timestamp missing while signature is present");
-                    return false; // timestamp missing with signature present
-                };
-
-                if !key.verify(message.as_bytes(), signature).is_ok() {
-                    tracing::debug!("signature does not match message");
-                    return false; // signature doesn't match
-                }
-
-                let now = time::SystemTime::now()
-                    .duration_since(time::UNIX_EPOCH)
-                    .unwrap();
-                if timestamp > (now + time::Duration::from_secs(30)) {
-                    tracing::warn!("command is more than 30s from the future");
-                    false
-                } else if now - timestamp <= time::Duration::from_secs(60) {
-                    // less than a minute old
-                    true
-                } else {
-                    tracing::warn!("command is more than a minute old");
-                    false
-                }
             }
             (Some(_), None) => false,
             (None, _) => true,
@@ -77,15 +49,11 @@ enum Command {
     Delete {
         id: Uuid,
     },
-    Status,
 }
 
 #[derive(Serialize)]
-pub enum ProxyResponse {
+pub struct ProxyResponse {
-    Message(String),
+    message: String,
-    Status {
-        tunnels: HashMap<Uuid, (u16, SocketAddr)>,
-    },
 }
 
 #[derive(Debug)]
@@ -100,7 +68,9 @@ impl GlobalState {
         Self {
             proxies: Mutex::new(HashMap::new()),
             ports: RwLock::new(HashSet::new()),
-            verifying_key: verifying_key.and_then(|key| VerifyingKey::from_str(key.as_ref()).ok()),
+            verifying_key: verifying_key
+                .map(|key| VerifyingKey::from_str(key.as_ref()).ok())
+                .flatten(),
         }
     }
 }
@@ -125,7 +95,9 @@ pub async fn process_command(
     if !payload.verify_signature(&state.verifying_key) {
         return (
             StatusCode::UNAUTHORIZED,
-            Json(ProxyResponse::Message("Invalid signature".to_string())),
+            Json(ProxyResponse {
+                message: "Invalid signature".to_string(),
+            }),
         );
     }
     match payload.command {
@@ -139,17 +111,17 @@ pub async fn process_command(
             if state.proxies.lock().unwrap().get(&id).is_some() {
                 return (
                     StatusCode::CONFLICT,
-                    Json(ProxyResponse::Message(
+                    Json(ProxyResponse {
-                        "Id already exists. Use the modify command instead.".to_string(),
+                        message: "Id already exists. Use the modify command instead.".to_string(),
-                    )),
+                    }),
                 );
             }
             if !state.ports.write().unwrap().insert(incoming_port) {
                 return (
                     StatusCode::CONFLICT,
-                    Json(ProxyResponse::Message(format!(
+                    Json(ProxyResponse {
-                        "The `incoming_port` already in use: {incoming_port}"
+                        message: format!("The `incoming_port` already in use: {incoming_port}"),
-                    ))),
+                    }),
                 );
             }
 
@@ -166,11 +138,11 @@ pub async fn process_command(
             add_proxy(incoming_port, rx).await.unwrap(); // TODO: error propagation??
             (
                 StatusCode::ACCEPTED,
-                Json(ProxyResponse ::
+                Json(ProxyResponse {
-                    Message( format!(
+                    message: format!(
                         "Created tunnel {id} on port {incoming_port} to use {destination_ip}:{destination_port}"
                     ),
-                )),
+                }),
             )
         }
         Command::Modify {
@@ -189,14 +161,18 @@ pub async fn process_command(
                     .unwrap();
                 (
                     StatusCode::ACCEPTED,
-                    Json(ProxyResponse::Message(format!(
+                    Json(ProxyResponse {
-                        "Changed tunnel {id} to use {destination_ip}:{destination_port}"
+                        message: format!(
-                    ))),
+                            "Changed tunnel {id} to use {destination_ip}:{destination_port}"
+                        ),
+                    }),
                 )
             } else {
                 (
                     StatusCode::NOT_FOUND,
-                    Json(ProxyResponse::Message(format!("Id not found: {id}"))),
+                    Json(ProxyResponse {
+                        message: format!("Id not found: {id}"),
+                    }),
                 )
             }
         }
@@ -206,27 +182,19 @@ pub async fn process_command(
                 state.ports.write().unwrap().remove(&proxy.incoming_port);
                 (
                     StatusCode::ACCEPTED,
-                    Json(ProxyResponse::Message(format!("Deleted tunnel: {id}"))),
+                    Json(ProxyResponse {
+                        message: format!("Deleted tunnel: {id}"),
+                    }),
                 )
             } else {
                 (
                     StatusCode::NOT_FOUND,
-                    Json(ProxyResponse::Message(format!("Id not found: {id}"))),
+                    Json(ProxyResponse {
+                        message: format!("Id not found: {id}"),
+                    }),
                 )
             }
         }
-        Command::Status => (
-            StatusCode::OK,
-            Json(ProxyResponse::Status {
-                tunnels: state
-                    .proxies
-                    .lock()
-                    .unwrap()
-                    .iter()
-                    .map(|(key, value)| (*key, (value.incoming_port, value.destination)))
-                    .collect(),
-            }),
-        ),
     }
 }
 
@@ -237,7 +205,7 @@ enum ProxyControlMessage {
 }
 
 async fn add_proxy(in_port: u16, control: Receiver<ProxyControlMessage>) -> anyhow::Result<()> {
-    let listener = TcpListener::bind(("0.0.0.0", in_port)).await?;
+    let listener = TcpListener::bind(("127.0.0.1", in_port)).await?;
 
     tracing::info!("proxying port {in_port} to {:?}", *control.borrow());
 
@@ -336,10 +304,7 @@ async fn transfer(
 
 #[cfg(test)]
 mod tests {
-    use std::{
+    use std::net::{IpAddr, Ipv4Addr};
-        net::{IpAddr, Ipv4Addr},
-        time,
-    };
 
     use crate::{Command, ProxyCommand};
     use p384::{
@@ -359,12 +324,10 @@ mod tests {
                 destination_ip: IpAddr::V4(Ipv4Addr::new(127, 0, 0, 1)),
                 id: uuid!("67e55044-10b1-426f-9247-bb680e5fe0c8"),
             },
-            timestamp: Some(8888),
             signature: Some(signature),
         };
         let expected = "{\"create\":{\"incoming_port\":5555,\"destination_port\":6666,\"\
                         destination_ip\":\"127.0.0.1\",\"id\":\"67e55044-10b1-426f-9247-bb680e5fe0c8\"},\
-                        \"timestamp\":8888,\
                         \"signature\":\"\
                             5C912C4B3BFF2ADB49885DCBDB53D6D3041D0632E498CDFF\
                             2114CD2DCAC936AB0901B47C411E5BB57FE77BEF96044940\
@@ -382,11 +345,9 @@ mod tests {
             command: Command::Delete {
                 id: uuid!("67e55044-10b1-426f-9247-bb680e5fe0c8"),
             },
-            timestamp: Some(987654),
             signature: Some(signature),
         };
         let expected = "{\"delete\":{\"id\":\"67e55044-10b1-426f-9247-bb680e5fe0c8\"},\
-                        \"timestamp\":987654,\
                         \"signature\":\"\
                             5C912C4B3BFF2ADB49885DCBDB53D6D3041D0632E498CDFF\
                             2114CD2DCAC936AB0901B47C411E5BB57FE77BEF96044940\
@@ -398,11 +359,6 @@ mod tests {
 
     #[test]
     fn verify_signature() {
-        let subscriber = tracing_subscriber::FmtSubscriber::builder()
-            .with_max_level(tracing::Level::TRACE)
-            .finish();
-        tracing::subscriber::set_global_default(subscriber).unwrap();
-
         let command = Command::Create {
             incoming_port: 4567,
             destination_port: 7654,
@@ -412,18 +368,12 @@ mod tests {
 
         // Create signed message
         let signing_key = SigningKey::random(&mut OsRng);
-        let timestamp = time::SystemTime::now()
+        let message = serde_json::to_string(&command).unwrap();
-            .duration_since(time::UNIX_EPOCH)
-            .unwrap()
-            .as_secs();
-        let mut message = serde_json::to_string(&command).unwrap();
-        message.push_str(&timestamp.to_string());
         let signature: Signature = signing_key.sign(message.as_bytes());
         let bytes = signature.to_bytes();
         assert_eq!(bytes.len(), 96);
         let proxy_command = ProxyCommand {
             command,
-            timestamp: Some(timestamp),
             signature: Some(signature),
         };
 

src/main.rs

@@ -3,17 +3,11 @@ use axum::{
     Router,
 };
 use proxima_centauri::{process_command, root, GlobalState};
-use std::sync::Arc;
+use std::{net::SocketAddr, sync::Arc};
 use tracing::Level;
 
 #[tokio::main]
 async fn main() {
-    let addr: std::net::SocketAddr = std::env::args()
-        .nth(1)
-        .unwrap_or_else(|| "127.0.0.1:14000".to_string())
-        .parse()
-        .unwrap();
-
     // initialize tracing
     let subscriber = tracing_subscriber::FmtSubscriber::builder()
         .with_max_level(Level::INFO)
@@ -33,6 +27,7 @@ async fn main() {
         .with_state(shared_state);
 
     // run our app with hyper
+    let addr = SocketAddr::from(([127, 0, 0, 1], 3000));
     tracing::debug!("listening  on {}", addr);
     axum::Server::bind(&addr)
         .serve(app.into_make_service())

status.sh

@@ -1,5 +0,0 @@
-curl --header "Content-Type: application/json" \
-  --data '{
-            "status": null
-          }' \
-  http://localhost:14000/command